[AST] ASTPrinter: convert canAppearOnDecl into an assertion
#87061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to swiftlang#86967. The callers are responsible for constructing declarations that are valid, let's double-check that all of the attached attributes to the declaration can indeed appear on it before printing instead of simply skipping them.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test source compatibility |
Contributor
|
IMO we should assert this when we add an attribute to a Decl |
Contributor
Author
|
That makes sense, I just want to see what breaks before I do a bigger refactoring here. |
Contributor
Author
@slavapestov Moving this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #86967.
The callers are responsible for constructing declarations that are valid, let's double-check that all of the attached attributes to the declaration can indeed appear on it before printing instead of simply skipping them.