Open
Conversation
GromNaN
force-pushed
the
flex-test-contrib
branch
from
7bfeaef to
40b8e0f
Compare
stof
requested changes
Jan 14, 2026
src/Flex.php
Outdated
| if (property_exists(Flex::class, 'storedOperations') && Flex::$storedOperations) { | ||
| $this->operations = Flex::$storedOperations; | ||
| Flex::$storedOperations = []; | ||
| if (property_exists(self::class, 'storedOperations') && self::$storedOperations) { |
Member
There was a problem hiding this comment.
this must be reverted. Not using self is intended here due to the special behavior of composer plugin classes during an update of the plugin (see the comment just above)
Member
Author
There was a problem hiding this comment.
Thanks for spotting the reason, I blindly applied the fabbot patch.
This is now reverted.
src/Flex.php
Outdated
| // Using `Flex::` instead of `self::` to avoid issues when | ||
| // composer renames plugin classes when upgrading them | ||
| Flex::$storedOperations = $this->operations; | ||
| self::$storedOperations = $this->operations; |
Member
There was a problem hiding this comment.
this must be reverted (see the comment just above for the explanation)
GromNaN
force-pushed
the
flex-test-contrib
branch
from
40b8e0f to
7bfeaef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is equivalent to the composer config
extra.symfony.allow-contrib. When the variable is set, its value has priority overextra.symfony.allow-contrib