-
Notifications
You must be signed in to change notification settings - Fork 48
fix(#1058): add date serialization #1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(#1058): add date serialization #1059
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1059 +/- ##
=======================================
Coverage 97.29% 97.30%
=======================================
Files 21 21
Lines 1666 1668 +2
=======================================
+ Hits 1621 1623 +2
Misses 45 45 🚀 New features to boost your workflow:
|
|
Thank you for putting up a PR! Cases to consider:
Test coverage will need to be added as well |
i'll expand the test cases to cover for the the serialization of the date part. edit: i see now the comment on the issue so im guessing you'd like to see a change to datetime adding timezones based on IOS8601? |
|
Ah, I didn't notice that. Yeah it looks like datetime is already supported and we just missed date. Looks like datetime already includes "%z" for the timezone offset. Looking at this further, what you have for "date" makes sense to me. So it's just the test cases missing at this point. Note that this is a breaking change, so I might defer cutting a new release until there's some other changes that can be batched together. We can still get this into the main branch though (I need to revisit our release system to figure out how we can get prereleases working). |
Sounds good to me and is totally understandable |
make .scripts/bootstrap posix compliant update to new timezone api
|
@noahnu let me know if this is good for you or if anything is missing |
| #### Environment requirements | ||
|
|
||
| - `pyenv` | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can take this out. It's going away once #1049 is merged, just haven't had the time to get back to it yet
| "foo": { | ||
| "x": "y", | ||
| "another_date": datetime.datetime.utcnow(), | ||
| "another_date": datetime.datetime.now(datetime.UTC), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't supported by Python 3.10 which is the minimum version of Python we support. EOL is Oct 2026. If you wanted to write a test that uses the newer syntax, you would need to use a mark to conditionally run the test on >3.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ill adapt
Description
see #1058
Checklist
Additional Comments
No additional comments.