Skip to content

Conversation

@danielnehrig
Copy link

Description

see #1058

Checklist

  • This PR has sufficient documentation.
  • This PR has sufficient test coverage.
  • This PR title satisfies semantic convention.

Additional Comments

No additional comments.

@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1059   +/-   ##
=======================================
  Coverage   97.29%   97.30%           
=======================================
  Files          21       21           
  Lines        1666     1668    +2     
=======================================
+ Hits         1621     1623    +2     
  Misses         45       45           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@noahnu
Copy link
Collaborator

noahnu commented Jan 2, 2026

Thank you for putting up a PR!

Cases to consider:

  • Timezones
  • Datetime

Test coverage will need to be added as well

@danielnehrig
Copy link
Author

danielnehrig commented Jan 2, 2026

Thank you for putting up a PR!

Cases to consider:

* Timezones

* Datetime

Test coverage will need to be added as well

datetime is already implemented afaik above my change.
timezones i'm not too sure where you see the need of timezones for the serialization aspect of a calendar date ?
i certainly see it for the datetime.datetime being useful
if you could kindly fill me in on your thoughts about the timezone addition that would be appreciated.

i'll expand the test cases to cover for the the serialization of the date part.

edit: i see now the comment on the issue so im guessing you'd like to see a change to datetime adding timezones based on IOS8601?

@noahnu
Copy link
Collaborator

noahnu commented Jan 2, 2026

Ah, I didn't notice that. Yeah it looks like datetime is already supported and we just missed date. Looks like datetime already includes "%z" for the timezone offset.

Looking at this further, what you have for "date" makes sense to me. So it's just the test cases missing at this point.

Note that this is a breaking change, so I might defer cutting a new release until there's some other changes that can be batched together. We can still get this into the main branch though (I need to revisit our release system to figure out how we can get prereleases working).

@danielnehrig
Copy link
Author

Ah, I didn't notice that. Yeah it looks like datetime is already supported and we just missed date. Looks like datetime already includes "%z" for the timezone offset.

Looking at this further, what you have for "date" makes sense to me. So it's just the test cases missing at this point.

Note that this is a breaking change, so I might defer cutting a new release until there's some other changes that can be batched together. We can still get this into the main branch though (I need to revisit our release system to figure out how we can get prereleases working).

Sounds good to me and is totally understandable

@danielnehrig
Copy link
Author

@noahnu let me know if this is good for you or if anything is missing

Comment on lines +75 to +78
#### Environment requirements

- `pyenv`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can take this out. It's going away once #1049 is merged, just haven't had the time to get back to it yet

"foo": {
"x": "y",
"another_date": datetime.datetime.utcnow(),
"another_date": datetime.datetime.now(datetime.UTC),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't supported by Python 3.10 which is the minimum version of Python we support. EOL is Oct 2026. If you wanted to write a test that uses the newer syntax, you would need to use a mark to conditionally run the test on >3.10

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill adapt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants