Optionnal endpoint namespace support#120
Open
noirbizarre wants to merge 2 commits intosyrusakbary:masterfrom
noirbizarre:namespace
Open
Optionnal endpoint namespace support#120noirbizarre wants to merge 2 commits intosyrusakbary:masterfrom noirbizarre:namespace
noirbizarre wants to merge 2 commits intosyrusakbary:masterfrom
noirbizarre:namespace
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Using Flask-SuperAdmin, I've been having a lot of url name collision with automatic endpoint creation for
ModelAdmin.To avoid collision, I wanted to prefix all URLs names with
admin.and keep the index view at root.This PR is doing that. It does not modify the default behavior but allow to easily prefix all admin views endpoints with a common prefix so I can write this:
This way I can keep the
user.listurl name for the non-admin view without manually specifying an endpoint for each view.I'm ready to discuss this choice and the other alternatives you can offer.
(I also renamed the
setup()intosetup_admin()intest_model.pybecause it was call twice).