Check Safari version if it supports TCO for Wasm#522
Merged
jserv merged 1 commit intosysprog21:masterfrom Dec 21, 2024
Merged
Conversation
ChinYikMing
force-pushed
the
safari-wasm-lto
branch
2 times, most recently
from
fe0dae8 to
c4943cb
Compare
ChinYikMing
changed the title
ChinYikMing
force-pushed
the
safari-wasm-lto
branch
from
c4943cb to
a30f262
Compare
jserv
reviewed
Dec 20, 2024
Safari has supported TCO for Wasm since version 18.2. To reflect for this, check the Safari version if the host machine is running macOS. Check Webassembly section at https://webkit.org/blog/16301/webkit-features-in-safari-18-2
Collaborator
Author
|
To avoid CI fails, removing redundant Wasm assets delegated to #505 since it will trigger the CI |
ChinYikMing
force-pushed
the
safari-wasm-lto
branch
from
a30f262 to
c617a29
Compare
Contributor
|
Thank @ChinYikMing for contributing! |
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
Check Safari version if it supports TCO for Wasm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari has supported TCO for Wasm since version 18.2. To reflect for this, check the Safari version if the host machine is running macOS.
Check Webassembly section at here.
Doom_demo.mov