Bump cookstyle from 3.0.0 to 6.19.5

[dependabot-preview]

Bumps cookstyle from 3.0.0 to 6.19.5.

Release notes

Sourced from cookstyle's releases.

Cookstyle 6.0.19

RuboCop 0.80.1 Engine

The RuboCop engine that powers Cookstyle has been updated from 0.75.1 to 0.80.1. This new engine includes hundreds of bug fixes and new features that will allow us to write even more advanced Cookstyle rules in the future. This release also renames many of RuboCop's built-in cops so if you have a complex rubocop.yml file that disables or enables rules, you may see warnings instructing you to update your config.

ChefDeprecation Cops At Warning Level

All ChefDeprecation department cops now alert at Warning level instead of Refactor. This means that these cops will now result in Cookstyle exiting with a -1 exit code, which will cause failures in CI tests. ChefDeprecation cops are important to resolve and we believe this will the use of the latest Chef Infra coding standards.

9 New Cops

ChefDeprecations/DeprecatedWindowsVersionCheck

The ChefDeprecations/DeprecatedWindowsVersionCheck cop detects cookbooks that use the legacy older_than_win_2012_or_8? helper method. Chef Infra Client no longer supports Windows releases before 8 / 2012. Those releases are end of life so this check can be removed from cookbooks.

ChefDeprecations/ChefWindowsPlatformHelper

The ChefDeprecations/ChefWindowsPlatformHelper cop detects cookbooks that use the deprecated helper Chef::Platform.windows? to see if a system is running on Windows instead of using platform?('windows') or the new windows? helper.

ChefDeprecations/LogResourceNotifications

The ChefDeprecations/LogResourceNotifications cop detects notifications in the log resource. Beginning in Chef Infra Client 16, the log resource will no longer trigger an update, so these notifications will never fire. This will create problems for users who concatenate notifications from multiple resources into a single log resource so that those notifications only fire a single time. For example, many resource updates in your cookbook may require a service to restart, but a user may only want to trigger that service to restart once. Chef Infra Client 15.8 and later ships with a notify_group resource specifically for aggregating notifications in this way. This resource should be used instead.

Aggregating Notifications with a log resource

template '/etc/foo' do
  source 'bar.erb'
  notifies :write, 'log[Aggregate notifications using a single log resource]', :immediately
end
log 'Aggregate notifications using a single log resource' do
notifies :restart, 'service[foo]', :delayed
end

Aggregating Notifications with a notify_group resource

template '/etc/foo' do
  source 'bar.erb'
  notifies :run, 'notify_group[Aggregate notifications using a single notify_group resource]', :immediately
end
notify_group 'Aggregate notifications using a single notify_group resource' do
notifies :restart, 'service[foo]', :delayed
end

ChefDeprecations/ResourceWithoutNameOrProvides

Changelog

Sourced from cookstyle's changelog.

v6.19.5 (2020-09-28)

Merged Pull Requests

• Simplify various cops #758 (tas50)
• Update RuboCop to 0.91.1 #761 (tas50)
• Catch more legacy metadata gating #759 (tas50)
• Run a single regex per comment line instead of 9 #760 (tas50)
• Update RuboCop to 0.92 #763 (tas50)
• Adds cops to detect Chef Vault usage. #762 (scottvidmar)
• Update the description for the new vault plugins #764 (tas50)

v6.18.8 (2020-09-17)

Merged Pull Requests

• Update RuboCop to 0.91 #748 (tas50)
• Add new ChefCorrectness/LazyInResourceGuard cop #750 (tas50)
• Backport a fix for Layout/RescueEnsureAlignment #749 (tas50)
• Enable Lint/RedundantRequireStatement cop #752 (tas50)
• Add new ChefCorrectness/PropertyWithoutType cop #751 (tas50)
• Enable 8 more RuboCop cops to simplify code #753 (tas50)
• Optimize our slowest cop #754 (tas50)
• Enable 3 new ruby cops & remove duplicate disables #756 (tas50)
• Cookstyle 6.18 release notes #755 (tas50)

v6.17.7 (2020-09-15)

Merged Pull Requests

• ChefCorrectness/IncorrectLibraryInjection: Avoid adding duplicate includes in autocorrection #747 (tas50)

v6.17.6 (2020-09-14)

Merged Pull Requests

• ChefCorrectness/IncorrectLibraryInjection: Catch more offenses #745 (tas50)

v6.17.5 (2020-09-11)

Merged Pull Requests

• Add missing description to rake task #738 (tas50)
• Replace uses of File.dirname(FILE) with dir #737 (tas50)
• Minor optimizations from rubocop-performance #739 (tas50)
• Remove unused stuff from spec_helper. #741 (phiggins)
• Spec cleanup from rubocop-rspec #740 (tas50)
• Add new deprecation cops to help people get off Chef 12 #742 (tas50)
• Add Cookstyle 6.17 release notes #743 (tas50)

v6.16.10 (2020-09-03)

Merged Pull Requests

• Enable Lint/Syntax cop that previously enabled by default #735 (tas50)

Commits

• ef41709 Bump version to 6.19.5 by Chef Expeditor
• dfd197e Merge pull request #764 from chef/update_description
• 3b14e3d Update the description for the new vault plugins
• a3fa4af Bump version to 6.19.4 by Chef Expeditor
• e0b0f68 Merge pull request #762 from scottvidmar/effortlessvault
• b5a4c79 Fix issues in PR for Chef Vault cops.
• 078d95d Bump version to 6.19.3 by Chef Expeditor
• 82b65bb Merge pull request #763 from chef/0.92
• dd79db4 Update RuboCop to 0.92
• 5e5a0ad Fix typos in cops_chefeffortless.md
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
• @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

• Update frequency (including time of day and day of week)
• Pull request limits (per update run and/or open at any time)
• Automerge options (never/patch/minor, and dev/runtime dependencies)
• Out-of-range updates (receive only lockfile updates, if desired)
• Security updates (receive only security updates, if desired)

[dependabot-preview]

Superseded by #197.