Misc fixes that prevented the login flow from working on takeout free#2
Conversation
|
After 
|
There was a problem hiding this comment.
Pull request overview
This pull request refactors the login page to simplify its layout and remove debug code. The changes streamline the authentication UI by removing animations and consolidating the layout structure from nested XStack/YStack to a single YStack hierarchy.
Changes:
- Removed debug console.info statement from Zero client
- Simplified login page layout from XStack with nested YStack to a single YStack structure
- Removed animation and transition properties from login buttons and elements
- Removed unused "waiting-list" screen from authentication navigation stack
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/zero/client.tsx | Removed debug console.info logging statement |
| app/(app)/auth/login.tsx | Refactored layout structure, removed animations/transitions, updated button styles, removed View import |
| app/(app)/auth/_layout.tsx | Removed unused waiting-list screen from navigation stack |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <Button | ||
| size="$5" | ||
| onPress={() => handleSocialLogin('google')} | ||
| pressStyle={{ | ||
| scale: 0.97, | ||
| bg: '$color2', | ||
| }} | ||
| hoverStyle={{ | ||
| bg: '$color2', | ||
| }} | ||
| transition="200ms" | ||
| enterStyle={{ opacity: 0, scale: 0.95 }} | ||
| icon={<GoogleIcon size={18} />} | ||
| flex={1} | ||
| /> | ||
|
|
||
| <Button | ||
| size="$5" | ||
| onPress={() => handleSocialLogin('apple')} | ||
| pressStyle={{ | ||
| scale: 0.97, | ||
| bg: '$color2', | ||
| }} | ||
| hoverStyle={{ | ||
| bg: '$color2', | ||
| }} | ||
| transition="200ms" | ||
| enterStyle={{ opacity: 0, scale: 0.95 }} | ||
| icon={<AppleIcon size={20} />} | ||
| flex={1} | ||
| /> |
There was a problem hiding this comment.
The Google and Apple social login buttons have lost all their interactive styling properties (pressStyle, hoverStyle, transition, and enterStyle). This removes visual feedback when users interact with these buttons. The native version of this file (login.native.tsx) still includes these properties, creating an inconsistency between platforms. Consider restoring these interactive styles for better user experience, or apply the same changes to the native version for consistency.
| import { router } from 'one' | ||
| import { useState } from 'react' | ||
| import { Circle, isWeb, SizableText, Spinner, View, XStack, YStack } from 'tamagui' | ||
| import { Circle, isWeb, SizableText, Spinner, XStack, YStack } from 'tamagui' |
There was a problem hiding this comment.
The PR description states that "Removed the unused isWeb and View imports from login.tsx", but isWeb is still imported and actively used on lines 47 and 48 to conditionally set padding and maxWidth. Only the View import was removed. The PR description should be corrected to reflect this.
|
thanks a bunch |
2 participants
This pull request refactors the login page UI and streamlines the authentication flow. The main focus is on simplifying the layout, improving visual consistency, and removing unused screens and debug code. Below are the most important changes grouped by theme:
UI and Layout Improvements:
LoginPagelayout from anXStackwith nestedYStackto a singleYStack, simplifying the structure and ensuring full-width and minimum height for better responsiveness.bg="$blue10") and removed transition/animation props for a cleaner look. Also addedSizableTextto the email button for better readability. [1] [2]Code Clean-up and Removal:
waiting-listscreen from the authentication stack, streamlining navigation.isWebandViewimports fromlogin.tsxfor cleaner code.console.infostatement fromsrc/zero/client.tsx.