Update Scanner class to provide options to init()#445
Draft
ryanohoro wants to merge 4 commits intotarget:masterfrom
Draft
Update Scanner class to provide options to init()#445ryanohoro wants to merge 4 commits intotarget:masterfrom
ryanohoro wants to merge 4 commits intotarget:masterfrom
Conversation
Contributor
|
FWIW, init wasn't designed to use options (probably because I didn't know a lot about software design at the time). But if you're going to do this, which seems pretty reasonable, then you might as well remove options from the scan methods because init isn't actually doing anything in this PR. I'm not sure how it would break existing deployments but "loading" options on init instead of every scan may save a few micro or milliseconds of runtime for each scan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the change
Scanners had an
init()function that could be used before the first execution of the scanner, however, it did not have access to the configoptions, limiting how useful it was.This PR adds the scanner options to
init()and updates all scanners with the new style, or a skeleton function.Describe testing procedures
Docker container builds properly.
Sample output
N/A
Checklist