Editorial: Simplify the algorithms for Array and TypedArray constructors#3544
Open
Editorial: Simplify the algorithms for Array and TypedArray constructors#3544
Conversation
Member
|
I'm fine removing the assertion, but the |
gibson042
force-pushed
the
2025-02-simplify-array-construction
branch
from
d367283 to
a445b8c
Compare
Member
Author
|
FWIW, I feel more strongly about the TypedArray changes than the Array ones, because for me the excessive indentation (not to mention vertical expansion) makes it hard to follow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some unnecessary condition nesting and a trivial assertion. The small scope of the changes is most obvious while ignoring whitespace.