Conversation
|
The rendered spec for this PR is available at https://tc39.es/proposal-typedarray-findwithin/pr/5. |
1ccd9c7 to
bd79d79
Compare
9f904b9 to
db7daad
Compare
bakkot
left a comment
There was a problem hiding this comment.
LGTM other than comment. I think later we might want to either define an AO for "SameValueZero-equal" or at least rephrase and put it somewhere which can be shared, but it's fine for now.
Also I continue to think these should all take an offset parameter, but that can be a followup.
|
Oh, and I also (weakly) still think the needle should be any iterable, which will be much more annoying to specify. But again, that can be a followup if that's the direction we decide to go. |
spec.emu
Outdated
| <h1>Properties of the %TypedArray% Prototype Object</h1> | ||
|
|
||
| <emu-clause id="sec-%typedarray%.prototype.search"> | ||
| <h1>%TypedArray%.prototype.search ( _needle_ )</h1> |
There was a problem hiding this comment.
indexOf already exists and I didn't want to overload it. 'search' is at least parallel with String.prototype.search but obviously doesn't have the regexp argument. 100% open to more suggested colors for the bikeshed here, just don't want to overload any of the existing method names
This comment was marked as resolved.
This comment was marked as resolved.
bce0c5f to
b8f65ae
Compare
245e216 to
088572c
Compare
088572c to
0d2d06c
Compare
No description provided.