Added ability for configuring auto reboot.#150
Open
henry54809 wants to merge 1 commit intotchellomello:masterfrom
Open
Added ability for configuring auto reboot.#150henry54809 wants to merge 1 commit intotchellomello:masterfrom
henry54809 wants to merge 1 commit intotchellomello:masterfrom
Conversation
houndci-bot
reviewed
Mar 3, 2020
| return ret.content.decode('utf-8') | ||
|
|
||
| def __set_config(self, *argv): | ||
| config_strs = "&".join(map(lambda pair: str(pair[0]) + "=" + str(pair[1]), argv)) |
| _KEEPALIVE_OPTS = HTTPConnection.default_socket_options + list(filter(lambda option: option[1], [ | ||
| (socket.SOL_SOCKET, socket.SO_KEEPALIVE, 1), | ||
| (socket.IPPROTO_TCP, socket.TCP_KEEPIDLE, KEEPALIVE_IDLE), | ||
| (socket.IPPROTO_TCP, socket.TCP_KEEPIDLE if hasattr(socket, "TCP_KEEPIDLE") else None, KEEPALIVE_IDLE), # TCP_KEEPIDLE doesn't exist for Mac |
There was a problem hiding this comment.
at least two spaces before inline comment
line too long (144 > 79 characters)
| _LOGGER = logging.getLogger(__name__) | ||
|
|
||
| _KEEPALIVE_OPTS = HTTPConnection.default_socket_options + [ | ||
| _KEEPALIVE_OPTS = HTTPConnection.default_socket_options + list(filter(lambda option: option[1], [ |
There was a problem hiding this comment.
Black would make changes.
line too long (97 > 79 characters)
tchellomello
requested changes
Jan 18, 2021
Owner
tchellomello
left a comment
tchellomello
left a comment
There was a problem hiding this comment.
@henry54809 sorry for the long delay in reviewing this. I'm back on looking at this project more closely.
Could you re-work your PR so we can get this merged? Basically lint issues and re-testing it against the latest master branch so we can validate the change? Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability for configuring auto reboot using API v3 of 2017 page 82. Tested with IP2M-841B. I want this ability so I can write a script to continuously configure the device's reboot time to be X mins in the future. This is for cases where the device's networking crashes between now and X mins in the future , it can immediately reboot and come back online.