Fix for multi select custom fields when saving#18
Open
Chucheen wants to merge 2 commits intoteachbase:masterfrom
Open
Fix for multi select custom fields when saving#18Chucheen wants to merge 2 commits intoteachbase:masterfrom
Chucheen wants to merge 2 commits intoteachbase:masterfrom
Conversation
For a multi_select field type, amoCRM demands to be a direct array instead of a values: { [value: '1']}.
This commit fixes the way it's sent
Author
|
Apparently Travis failed because of resolving or installing some dependencies |
lib/amorail/entity/params.rb
Outdated
| prop_id = props.send(k).id | ||
| prop_val = { value: send(k) }.merge(v) | ||
| custom_fields << { id: prop_id, values: [prop_val] } | ||
| prop_val = props.send(k)['type_id'] == "5" ? [send(k)] : { value: send(k) }.merge(value) |
Contributor
There was a problem hiding this comment.
what is "5" ? Can you explain ? I think you can use constant for that.
Author
There was a problem hiding this comment.
I changed it to use a constant instead. It's the field id for a multiselect type of field.
https://developers.amocrm.com/rest_api/accounts_current.php#type_id
Contributor
|
@ivanovaleksey Could you, please, take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a multi_select custom_field type, amoCRM demands to be a direct array
instead of
The multi select fields were not being stored from the beginning or when updated. This commit changes the way it's sent and fixes that