Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
I have successfully removed the dependency on the Convert module entirely. It turned out to require a very small number of changes in the project. Additionally, I also fixed some errors reported by PSScriptAnalyzer—without these fixes, I couldn't build the project.
I built and test the project as follows:
Installed InvokeBuild (version 5.14.22)
Installed PSScriptAnalyzer (version 1.24.0)
Installed platyPS (version 0.12)
Then, from the src directory, I ran Invoke-Build.
All tests passed successfully.
Issue
Issue #5: Install-Module pwshEmojiExplorer requires accepting -AllowClobber
Description
Removed dependency from Convert module.
Fixed some warnings of PSScriptAnalyzer to build and test project before creating this PR.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.