Open
Conversation
Arakos
commented
Feb 17, 2026
Arakos
commented
- improve API type validation to actually do as intended (fixes Controller is not able to patch InfobloxIPPool status conditions #132) + update it to support SSA patches for objects
- fix the known issue with infoblox not returning some fields for hostrecords by using the correct request method
- add basic infoblox error message parsing (falls back to raw error if not possible)
- automatically assert that a hostname for a claim has the DNSZone suffix if a dns zone is set on the referenced IPPool but the hostname does not have the exact zone as suffix
- fix makefile to generate any mocks on make generate
- fix setup (readme, make release) to correctly reflect latest clusterctl init requirements
- fixed controller params to correctly pass cert-key and name params to the related options struct
- adapt testcases to any changes
* improve API type validation to actually do as intended + update it to support SSA patches for objects * fix the known issue with infoblox not returning some fields for hostrecords by using the correct request method * add basic infoblox error message parsing (falls back to raw error if not possible) * automatically assert that a hostname for a claim has the DNSZone suffix if a dns zone is set on the referenced IPPool but the hostname does not have the exact zone as suffix * fix makefile to generate any mocks on make generate * fix setup (readme, make release) to correctly reflect latest clusterctl init requirements * fixed controller params to correctly pass cert-key and name params to the related options struct * adapt testcases to any changes
Arakos
commented
Feb 17, 2026
Comment on lines
+24
to
+27
| // if DNS is enabled but the hostname does not have the zone as suffix automatically assume it | ||
| if !strings.HasSuffix(hostname, dnsZone) { | ||
| hostname = fmt.Sprintf("%s.%s", hostname, dnsZone) | ||
| } |
Author
There was a problem hiding this comment.
This new behavior is also up for debate.
Is that a good idea, or should we instead validate that (if a dnsZone is configured) the hostname values must have the correct suffix?
If not, we should return an error, because if we don't, Infoblox will return one with a cryptic message.
(Same as #131 (comment))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.