fix: Add mandatory parent-interface for VLAN subinterfaces#60
Open
rbu9fe wants to merge 1 commit intotelekom:develfrom
Open
fix: Add mandatory parent-interface for VLAN subinterfaces#60rbu9fe wants to merge 1 commit intotelekom:develfrom
rbu9fe wants to merge 1 commit intotelekom:develfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that happens when there is a VLAN subinterface. It's similar to PR-49, however, instead of extracting the name of the parent's interface from the subinterface's name, we retrieve the real parent's name by a libnl query (inspired by the implementation of the bridging plugin).
Furthermore, some invalid paths of augmented nodes in common.h have been fixed.
Manual tests are passed.
@zinccyy, @iffy50 and/or @jvijtiuk: Could you please review the changes?