Skip to content

Conversation

@IvanDanchev
Copy link
Contributor

No description provided.

@IvanDanchev IvanDanchev added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Jan 15, 2026
@IvanDanchev IvanDanchev requested a review from a team as a code owner January 15, 2026 14:43
@github-actions
Copy link
Contributor

Hello @IvanDanchev,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

Copy link
Contributor

@dimodi dimodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting one line out can cause confusion. Consider these options:

  • Leave the comment, but clarify the reason in the code itself and in the text before the example.
  • Remove the comment and make the whole example non-runnable, because when it's runnable, it cannot fully demonstrate the discussed scenario.

In either case, the example looks complex for its simple goal. Consider adding one more example that uses the approach from our project template: use ExpandedChanged and do not update the Expanded parameter value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-to-production Use this label to get a comment to choose whether to merge the PR to production

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants