Remove 'enhanced' describe task-queue, no changes to tests yet #932
+18
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Remove 'enhanced' describe task-queue, no changes to tests yet
Why?
Enhanced mode is deprecated and clutters the
task-queue describecommand with lots of flags that are confusing. Unfortunately, when "enhanced" mode was first released in the server experimentally, it should have been marked experimental in the CLI. Instead, it was not marked experimental, and it was made to be the default.After redesign of the server-side describe task-queue API, the decision was made to go back to "legacy" API mode to expose configurations related to priority and fairness, as well as task queue stats. So, legacy should become the default again, and "enhanced" should be retired. The exact mechanism of this is debateable, but unfortunately I feel like the only path to a non-confusing future requires making a breaking change at some point. I propose to make the breaking change now, to minimize confusion as users adopt worker versioning and priority & fairness. Alternatively we could do a deprecation phase-out, but the naming of flags makes that quite unfortunate.
Checklist
Closes
How was this tested: