Attach worker_instance_key to all poll calls#2178
Draft
yuandrew wants to merge 3 commits intotemporalio:masterfrom
Draft
Attach worker_instance_key to all poll calls#2178yuandrew wants to merge 3 commits intotemporalio:masterfrom
yuandrew wants to merge 3 commits intotemporalio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Will wait for #2148 to merge, then add a test to ensure it's passed properly (even if Worker heartbeating is disabled), and the other shutdown types we added in
What was changed
Attach
worker_instance_keyto all poll calls. ShutdownWorker is being plumbed with #2148Why?
New API change, temporalio/api#686
Checklist
Closes
How was this tested:
Added tests