fix: throw correct exception from Activity and Workflow contexts#687
Merged
fix: throw correct exception from Activity and Workflow contexts#687
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
wolfy-j
reviewed
Jan 23, 2026
| use Temporal\Exception\OutOfContextException; | ||
| use Temporal\Workflow; | ||
|
|
||
| class WorkflowFacadeTest extends TestCase |
Collaborator
There was a problem hiding this comment.
we did not have existing one?
Collaborator
Author
There was a problem hiding this comment.
It uses in different tests to test workflow, but there's no any to test Temporal\Workflow itself
wolfy-j
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Closes #624
Checklist
Closes
How was this tested: