Allow for webpack resolve configs to be passed directly#908
Open
eloytoro wants to merge 2 commits intoternjs:masterfrom
Open
Allow for webpack resolve configs to be passed directly#908eloytoro wants to merge 2 commits intoternjs:masterfrom
eloytoro wants to merge 2 commits intoternjs:masterfrom
Conversation
Contributor
Author
|
Note: allowing to compile the config using babel-register adds a noticeable delay to server startup |
|
Until this is merged, is there a good workaround? |
Contributor
Author
|
@tyrocca the only work around would be to not use babel for the webpack config so it can be required directly as a node module |
Contributor
|
Another workaround is to make tern read |
Contributor
Author
|
The tern command isn't necessarily executed in the directory where the
project is, so I'm not sure that requiring local dependencies could be
feasible.
Still waiting on a maintainer for a response
…On Jun 14, 2017 8:05 AM, "Qiming zhao" ***@***.***> wrote:
Another workaround is to make tern read .babel.js and use the babel
module from the project to compile the config file before load, so no need
for add babel-core as a dependency to tern.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#908 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADwSBckZI0dVYjcwAgZ0r7gIHmfgT37Jks5sD3gggaJpZM4NfqNP>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now term supports passing the
configPathand themodulesoptions to the webpack plugin.As it so happens, webpack 2 natively supports configs to be written using ES6 modules because it transpiles the config using babel if it has the
.babel.jstermination.There are two ways to solve this as far as I can see.
The first solution is the best one for users in my opinion, being able to require their babel-esque config would silently fix the issue. If you guys like it we can close this PR and I can open another one that takes care of this.
The second solution is what I'm doing here, allowing to pass
"alias"to the config should fix the issue for now