Skip to content

Fix Ryuk disabled#234

Closed
gossi wants to merge 2 commits intotestcontainers:mainfrom
gossi:fix-ryuk-disabled
Closed

Fix Ryuk disabled#234
gossi wants to merge 2 commits intotestcontainers:mainfrom
gossi:fix-ryuk-disabled

Conversation

@gossi
Copy link
Contributor

@gossi gossi commented Feb 2, 2026

It's a fix for ryuk disabled as described in #228

14:36:22.211 [info] Docker host: {"http+unix://%2Fvar%2Frun%2Fdocker.sock", "unix:///var/run/docker.sock"}
********************************************************************************
Ryuk has been disabled. This can cause unexpected behavior in your environment.
********************************************************************************


14:36:22.215 [debug] Not running in docker environment, using localhost
** (EXIT from #PID<0.94.0>) {:ok, nil}

This PR uses this commit as a base: 8fbe1eb

That is, you can create a branch from the commit above: v1.* and we can set this as target branch for this PR, which allows your changes to stay unaffected but be able to release a hotfix.

In a second effort, this PR can be revived and applied onto the main branch, too.

@jarlah
Copy link
Member

jarlah commented Feb 2, 2026

do you think its possible to make any kind of test that can verify if the conditional reaper process generation works?

@jarlah
Copy link
Member

jarlah commented Feb 2, 2026

read your comment about base and v1 too late or didnt read it at all. You can force push over this. And about v2 and v1. We can backport later, when we have the update ready. I will make a branch from v1 at that time and cherry pick the commit over. and then release v1.14.1.

@jarlah
Copy link
Member

jarlah commented Feb 2, 2026

Ill make a quick release today. Will cherrypick into a v1 branch. Test can be added in v2

@jarlah
Copy link
Member

jarlah commented Feb 2, 2026

fixed in 2424aae and 6fd0cf0

@jarlah
Copy link
Member

jarlah commented Feb 2, 2026

added test here 6652b35

@jarlah
Copy link
Member

jarlah commented Feb 2, 2026

a pretty normal testrun now

Running ExUnit with seed: 782698, max_cases: 32

...........................................................................********************************************************************************
Ryuk has been disabled. This can cause unexpected behavior in your environment.
********************************************************************************

..........................
18:23:11.292 [error] kafka_server_produce_send_request: leader for topic auto_topic/0 is not available
.............
Finished in 123.3 seconds (27.9s async, 95.3s sync)
114 tests, 0 failures

on main ;)

@jarlah
Copy link
Member

jarlah commented Feb 2, 2026

i deleted v1 since its just making noise. If more backports are needed, new v1 branch must be created from the last tag

@jarlah jarlah closed this Feb 2, 2026
@gossi
Copy link
Contributor Author

gossi commented Feb 2, 2026

Hooray, thank you so much 🧡

@jarlah
Copy link
Member

jarlah commented Feb 2, 2026

@gossi you can also try to use v2.0.0-rc for the same purpose. Its basically the same but without the ecto module, improved kafka, cassandra and redis container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants