Open
Conversation
Member
|
looks useful :) should be very easy to test it in a isolated manner outside a container configuration. Just start a container with the exunit macro and then construct and call the strategy ? then another test would be to create a special container, maybe an nginx container, that serves a specific html file or something. However it seems to always take a map in the match function. Is it a requirement as the strategy is now that response must be json ? Should it require that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impl for #236
I originally build this for
Req. Then saw, there is Tesla. I followed their docs to build the client and make a request - I never used tesla before. I checked the response type from tesla and req and they are pretty equal for the response.While I tested this with
Req, this PR is completely untested - but I thought it's good enough to say hello :)