fix: ready condition in ClickHouse#441
Merged
DDtKey merged 1 commit intotestcontainers:mainfrom Dec 22, 2025
Merged
Conversation
Contributor
Author
|
@DDtKey , since you are already reviewing testcontainers/testcontainers-rs#896 if you could also take a look at this one I'd appreciate it very much since that would unblock my full integration test scenario. |
DDtKey
approved these changes
Dec 22, 2025
DDtKey
changed the title
Contributor
Author
|
Thanks again for the super quick reviews! I took a look at the CI failures and except for the PR title check, the rest seem unrelated (they apply to other modules like Weaveate and other stuff). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ClickHouse dockerfile exposes several ports (8123, 9000, etc.). If no port is specified in the
ready_conditionsthe first exposed one is chosen, which is non-deterministic. This means Clickhouse would fail to start (from the testcontainer's point of view).This PR explicitly adds the good port to the
ready_conditionsto fix that.