Fixed issue with app going into infinite loading on multiple images in the record#161
Merged
boris91 merged 3 commits intotetherto:devfrom Feb 12, 2026
Merged
Conversation
denislupookov
changed the title
boris91
previously approved these changes
Feb 11, 2026
giorgikh93
requested changes
Feb 11, 2026
Contributor
giorgikh93
left a comment
giorgikh93
left a comment
There was a problem hiding this comment.
Do order matter while comparing two arrays? any scenario it can change and we detect it as not equal? it's an edge case, even if so, +1 extra render wouldn't harm the performance but if you think an array ordering can be different at some point, we can normalize two arrays before comparing.
giorgikh93
approved these changes
Feb 11, 2026
boris91
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
The application does not go into an infinite loading state when trying to view an item with more than two photos
Changes
The infinite loop was caused by the application unconditionally updating form values every time files were loaded, which triggered a re-render and a new fetch. Was fixed by adding a check to only update the form when the loaded data is actually different from the existing values.
Screenshots/Recordings
Screen.Recording.2026-02-11.at.10.58.38.mov