Remove duplicate settings screen header#1025
Merged
bherbst merged 1 commit intothe-blue-alliance:mainfrom Feb 13, 2026
Merged
Conversation
gregmarra
approved these changes
Feb 13, 2026
Contributor
gregmarra
left a comment
gregmarra
left a comment
There was a problem hiding this comment.
LGTM! The title is already rendered in the top app bar via TBAApp.kt, so this correctly removes the duplicate.
Minor note: with this change, the settings screen is empty for release builds (all remaining content is behind BuildConfig.DEBUG). Not a problem for this PR, just something to be aware of when adding real settings later.
gregmarra
force-pushed
the
remove_duplicate_settings_header
branch
from
e20fef1 to
07094e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings screen currently has a duplicate title, now it doesn't!