Skip to content

WIP: Bold monitor with Balloon model#563

Draft
i-Zaak wants to merge 2 commits intomasterfrom
bold_monitor_int
Draft

WIP: Bold monitor with Balloon model#563
i-Zaak wants to merge 2 commits intomasterfrom
bold_monitor_int

Conversation

@i-Zaak
Copy link
Contributor

@i-Zaak i-Zaak commented May 9, 2022

This PR addresses the #562 .

Next steps are:

  • verify that the default parameters are reasonable (important - most users won't touch these)
  • convert relevant params to ms to get consistency with the other components?
  • refactor the analyzer to use the "replay" function and this monitor to avoid code duplicity

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
32.0% 32.0% Duplication

@maedoc
Copy link
Member

maedoc commented May 12, 2022

verify that the default parameters are reasonable

The parameters are lifted from a Friston paper I think, so they are at least defensible if not reasonable.

self.balloon_dfun,
neural_activity,
local_coupling=0.0, stimulus=0.0)
# if bold period, yeet current state
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, excellent choice of word here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants