Fix Dockerfile: use PATH instead of ENTRYPOINT for venv#384
Merged
theGreatHerrLebert merged 1 commit intomainfrom Feb 6, 2026
Merged
Fix Dockerfile: use PATH instead of ENTRYPOINT for venv#384theGreatHerrLebert merged 1 commit intomainfrom
theGreatHerrLebert merged 1 commit intomainfrom
Conversation
Replace fixed python ENTRYPOINT with adding the venv to PATH so users can run any command directly (e.g. docker run rustims timsim --help). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ENTRYPOINT ["/opt/venv/bin/python"]withENV PATH="/opt/venv/bin:${PATH}"docker run rustims timsim --helppython --versionTest plan
docker run --rm rustims timsim --help→ shows timsim usagedocker run --rm rustims python -c "import torch"→ worksdocker run --rm rustims→ prints Python version🤖 Generated with Claude Code