-
Notifications
You must be signed in to change notification settings - Fork 35
Add support for async disposable #1073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joshamaju
wants to merge
26
commits into
thefrontside:v4
Choose a base branch
from
joshamaju:native-disposable-resource
base: v4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+229
−56
Open
Changes from 2 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
0dfd71e
feat: Implement `Symbol.asyncDispose` on tasks to enable `await using…
joshamaju d884d25
Corrects formatting
joshamaju 805ad9d
refactor: move `Symbol.dispose` from `Future` to `Task` interface.
joshamaju 370541a
refactor: simplify Task's asyncDispose method implementation
joshamaju 18e228d
refactor: remove await from task halt in test
joshamaju 9bc8f78
refactor: relocate task error handler to outside `await using` block …
joshamaju 2681228
fix: provide async dispose types
joshamaju d1acb33
feat: adds automatic scope closing for createScope
joshamaju 6e40c44
roll back formatting changes
cowboyd 7906f51
Move `AsyncDisposable` into `ScopeInternal`
cowboyd 10a2f26
docs: adds documentation for `AsyncDisposable` support for `Task` and…
joshamaju 1436bf0
feat: adds support for both normal variable assignment and destructur…
joshamaju 2be74e4
refactor: update type definitions for createScope and improve test ca…
joshamaju ff59169
Merge branch 'v4' into native-disposable-resource
joshamaju 9d889b7
chore: fix formating
joshamaju b736ceb
chore: fix formating
joshamaju 3ef5fde
Merge branch 'native-disposable-resource' of https://github.com/josha…
joshamaju 3a0fa1a
Merge branch 'native-disposable-resource' of https://github.com/josha…
joshamaju efb2591
Merge branch 'native-disposable-resource' of https://github.com/josha…
joshamaju 8a0c134
✨ Explicit Resource Management for Task and Scope
joshamaju 80f6b93
Merge branch 'native-disposable-resource' of https://github.com/josha…
joshamaju a0227b9
Add using() API with runtime validation and tests
joshamaju a8fd70c
chore: format
joshamaju 72eefeb
chore: format
joshamaju 669c458
Merge branch 'native-disposable-resource' of https://github.com/josha…
joshamaju f08cf53
Revert "Add using() API with runtime validation and tests"
joshamaju File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.