Updated browserVersion and version to behave the same#1117
Open
samends wants to merge 1 commit intotheintern:master-oldfrom
Open
Updated browserVersion and version to behave the same#1117samends wants to merge 1 commit intotheintern:master-oldfrom
samends wants to merge 1 commit intotheintern:master-oldfrom
Conversation
- When version is set to 'insider preview' and browserName is 'MicrosoftEdge', the driver name should be 'MicrosoftEdgeChromium
|
|
samends
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1117 +/- ##
==========================================
- Coverage 57.44% 57.34% -0.11%
==========================================
Files 95 95
Lines 8909 8911 +2
Branches 2046 2048 +2
==========================================
- Hits 5118 5110 -8
- Misses 3791 3801 +10
Continue to review full report at Codecov.
|
jason0x43
requested changes
Mar 5, 2020
Member
jason0x43
left a comment
jason0x43
left a comment
There was a problem hiding this comment.
This does handle the Edge case, but we should try to deal with this at an earlier point if possible, possibly in src/core/lib/common/util#processOption, to cover that and the BrowserStack case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When version is set to
insider previewand browserName isMicrosoftEdge, the driver name should beMicrosoftEdgeChromiumresolves: #1113