Support debug logging (#1150)#1207
Open
abolfazlghalandary wants to merge 1 commit intotheintern:masterfrom
Open
Support debug logging (#1150)#1207abolfazlghalandary wants to merge 1 commit intotheintern:masterfrom
abolfazlghalandary wants to merge 1 commit intotheintern:masterfrom
Conversation
jason0x43
requested changes
Jan 27, 2023
Member
jason0x43
left a comment
jason0x43
left a comment
There was a problem hiding this comment.
Hi, and thanks for contributing! You should be able to simplify this one a bit. The reporter itself doesn't need to worry about whether debug mode is enabled, it just needs to handle log events.
|
|
||
| @eventHandler() | ||
| log(data: any) { | ||
| if (this._debugLogs) { |
Member
There was a problem hiding this comment.
The reporter doesn't actually need to check any sort of debug condition. Other parts of Intern handle that (see log in src/lib/executors/Executor.ts), so the Console reporter should simply need to implement a handler for the log event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1150
I'm solving this issue as a "good first issue". Since I have little experience on frontend, and this is one of my first contributions, I appreciate any step-by-step help to make this PR applicable for merging.
Thanks!