Added 2 options to Visual regression reporter#17
Open
GARMBoshouwers wants to merge 1 commit intotheintern:masterfrom
Open
Added 2 options to Visual regression reporter#17GARMBoshouwers wants to merge 1 commit intotheintern:masterfrom
GARMBoshouwers wants to merge 1 commit intotheintern:masterfrom
Conversation
GARMBoshouwers
commented
Oct 11, 2019
- onlyReportErrors: Only display visual regressions in the report. Default option is false, so all tested screenshots are added to the report, which was the original system. When set to true, only reports that did not pass are added to the report, which makes it easier to find regressions by testers.
- prefixTestName: Prefix the test name in the report with the parent test suite names. Default option is false, so the Comparison Header is the same as the original system. When set to true, the Comparison header is prefixed with the parent suite names to distinguish them in multi-suite runs.
- onlyReportErrors: Only display visual regressions in the report - prefixTestName: Prefix the test name in the report with the parent test suite names
Author
|
Is there something more I have to do for that CLA? I clicked on the details of that check and agreed there as far as I can see, but it is still pending. |
Member
|
Hmmm... there shouldn't be. I'll look into it. |
Member
|
If you click the Details link now, does it tell you that you have signed the CLA? |
Author
|
First I get the form where I need to sign in with my GitHub credentials. If I do that, it says "You have signed the CLA for theintern/visual-plugin", so I assumed it should be correct. |
Author
|
Hmm, I did sign that agreement with my personal email, but I made the commit with my work account. These two adresses are both connected to my GitHub account. Could that be a problem? |
Member
|
It's possible. Try updating the commit with your personal email and force-push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.