Hook the CreateDirectory*() functions#122
Open
TheComputerGuy96 wants to merge 1 commit intothelink2012:masterfrom
Open
Hook the CreateDirectory*() functions#122TheComputerGuy96 wants to merge 1 commit intothelink2012:masterfrom
TheComputerGuy96 wants to merge 1 commit intothelink2012:masterfrom
Conversation
ZMenu calls CreateDirectoryW() to create the ZMenu directory for storing some .ini files (which currently ends up in the root game folder)
Owner
|
Hey @TheComputerGuy96. Thanks for your contribution. I'll merge both this and #120 and publish a new release soon. Just worried that this may cause some side-effect somewhere it shouldn't. But so far I've not thought of a edge case. |
|
@thelink2012 hey, any news on that release? |
Owner
|
Hey @SandeMC, a bit busy here so I'll probably not be able to merge this before May. |
Hey, i hope you're not busy now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZMenu still doesn't fully work with modloader though (the strings for the
Mod Configurationmenu are all empty which doesn't happen when using a normal ASI loader)Maybe that issue could be worked around by delaying the loading of the modloader strings (but the mod should probably be fixed itself with some memory patches?)