feat: button to download picture outside of ngx-lightbox#161
Open
pierresh wants to merge 12 commits intothemyth92:masterfrom
Open
feat: button to download picture outside of ngx-lightbox#161pierresh wants to merge 12 commits intothemyth92:masterfrom
pierresh wants to merge 12 commits intothemyth92:masterfrom
Conversation
This is necessary when per example the API requires a JWT in the header
|
Looks good |
|
This looks like a great feature, and I would like to get started using it as soon as possible. |
Author
|
Yes, it would be great if it could be merged and available on npm :) For the time being, you could unzip and replace this folder in |
pierresh
force-pushed
the
master
branch
4 times, most recently
from
ebe9454 to
82dfb5c
Compare
Author
|
Unfortunately, this library seems not maintained anymore. For those interested in this feature I created an npm package (also includes its update to Angular 17).
|
Version number match with Angular, that is easier to follow-up
added 3 commits
December 22, 2024 01:39
ng update @angular/core@18 @angular/cli@18
ng update @angular/core@19 @angular/cli@19
ng update @angular/core@20 @angular/cli@20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this commit, we can receive an event when the end-user clicks on the Download button, and then the download of the picture can be handled in the web app, outside of ngx-lightbox, it is then possible to use an authentication token for example.