This repository was archived by the owner on Feb 13, 2019. It is now read-only.
Fully Documented and Object Oriented Fart#42
Open
3den wants to merge 1 commit intotheonion:masterfrom
Open
Conversation
Contributor
Author
|
@csinchok I think you will love this ;) |
Contributor
|
I do like this a lot. I'll be merging it shortly, with a few other additions. |
|
great effort! (y) |
Contributor
Author
|
@monobasic thanks :) |
Contributor
Author
|
@csinchok let me know if we need some more changes on this code, I really want to get it merged to start using fart on button clicks and form validations ;) |
Contributor
Author
|
@csinchok do you want to pass this project to me? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactoring of the
fartscroll.jswont change any existent behavior, the smell will be the same. When this is merged the code will be much more beautiful and we will be able to fart anywhere we want too.The
fartscrollmethod got much simpler and now we should be able to make other events fart, you can fart on the command line, or on form validations... basically now you should be able to fart anyway you like and anywhere you want.