Allow configuring retain_visibility on Filesystem#195
Merged
maxhelias merged 4 commits intothephpleague:3.xfrom Dec 11, 2025
Merged
Allow configuring retain_visibility on Filesystem#195maxhelias merged 4 commits intothephpleague:3.xfrom
maxhelias merged 4 commits intothephpleague:3.xfrom
Conversation
…lesystem definitions
rvanlaak
changed the title
rvanlaak
force-pushed
the
feat/retain-visibility-config
branch
from
598d311 to
9c6defe
Compare
Updated retain_visibility to allow null value for visibility checks.
Clarified the behavior of retain_visibility in the configuration reference.
maxhelias
approved these changes
Dec 11, 2025
Collaborator
maxhelias
left a comment
maxhelias
left a comment
There was a problem hiding this comment.
Thanks for adding this feature, which has not been followed up on here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of thephpleague/flysystem#1732 an thephpleague/flysystem#1721
This PR implements
retain_visibilityas configuration values on the bundle.Without this change, calling
moveorcopyon a Cloudflare R2 bucket will lead to an exception as ACL methods are not implemented yet.