Open
Conversation
This commit compiles and passes tests against HBase 0.94.16 + Hadoop 1.0.4 and against HBase 0.96.1.1-hadoop2 + Hadoop 2.2.0. Several things still need work: titan-dist's dependency on titan-hbase is no longer complete and effective since that's just a pom, some of the hadoop dependencies need to be made optional and/or provided/test scoped, probably some other stuff...
Marking both the hbase and hadoop-core dependencies as optional to make users redeclare the dependencies with their chosen distribution/version.
HBase 0.96 + hadoop1 is possibly broken pending https://issues.apache.org/jira/browse/HBASE-10494 HBase 0.96 + hadoop2 compiles and tests against Hadoop 2.2.0. This is the default build configuration of the titan-hbase-096 module.
Fixes a ClassNotFoundException during HBase minicluster startup in testing of the HBase 0.96 + hadoop1 build
I initiall copied over 0.94's shell scripts to the 0.96 test environment, but there have been a lot of changes between 0.94 -> 0.96, so I pulled the scripts in 0.96.1.1-hadoop1's tarball distribution. I patched bin/hbase's classpath cache logic to be compatible with our maven build environment. A bin/hbase patch is included in this commit as a convenience.
Member
|
Thanks @erickt. We will leave this PR open for people to grab it but we won't support it for the 0.4.x line of Titan but only in 0.5.x and onward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports @dalaro's hadoop 2.2 support back onto 0.4.2. I don't necessarily expect this PR to be landed as is though. If this is worthwhile, I would suggest instead landing it as a separate branch so people can upgrade to hadoop 2.2 distributions and continue to use Titan 0.4.2 in production while 0.5.0 is in development.