Remove example/node_modules folder to fix npm install issues#154
Open
cstigler wants to merge 1 commit intothlorenz:masterfrom
Open
Remove example/node_modules folder to fix npm install issues#154cstigler wants to merge 1 commit intothlorenz:masterfrom
cstigler wants to merge 1 commit intothlorenz:masterfrom
Conversation
joelgardner
added a commit
to Radico/brace
that referenced
this pull request
Apr 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
example/node_modulesfolder in order to fix some issues I found - specifically, I was unable to installbracefrom the GitHub repo using a recent version of npm.Backstory
Using node
10.15.0and npm6.4.1, I was having issues installingbrace. Specifically, it worked when I just usednpm install brace, but not when I rannpm install brace@thlorenz/bracewhich should install the version on GitHub. I verified that this was the case even using alternative parameters, for example thehttps://andgit://URLs.When trying to install this repo from GitHub, I received a
premature closeerror from npm, and upon further digging in the logs found the relevant error message:silly fetchPackageMetaData error for brace@github:thlorenz/brace premature close. Although this looks like a problem with thepackage.jsonfile, I didn't see any.After some investigation, it looks like the
example/node_modulesfolder was causing the issues installing from GitHub. While I don't understand the npm install internals, my guess is that the symlinks are the cause of the issues.Luckily, these seem to be very non-essential files - anybody looking to use the example can just run
npm installthemselves if they'd like - so deleting them seems like a good option to save frustration in the future!Testing
Not much should be required, since this is only touching example files.