Replace multiple validators by the composite validator

Author: thofman

src/Command/AddArticle.php

@@ -16,6 +16,7 @@
 use thofman\KnowledgeBase\Domain\Question\Sanitization\StringSanitizer;
 use thofman\KnowledgeBase\Domain\Question\Tag;
 use thofman\KnowledgeBase\Domain\Question\Validation\AlwaysValidValidator;
+use thofman\KnowledgeBase\Domain\Question\Validation\CompositeValidator;
 use thofman\KnowledgeBase\Domain\Question\Validation\NonEmptyStringValidator;
 use thofman\KnowledgeBase\Domain\Question\Validation\UrlSchemeHttpsValidator;
 use thofman\KnowledgeBase\Domain\Question\Validation\UrlValidator;
@@ -44,20 +45,13 @@ public function execute(InputInterface $input, OutputInterface $output): int
         $urlQuestion = new Question('Please enter the URL of the article: ', '');
         $urlQuestion->setValidator(
             static function (string $value): string {
-                $nonEmptyStringValidator = new NonEmptyStringValidator('URL');
-                $validationResult = $nonEmptyStringValidator->validate($value);
-                if (!$validationResult->isValid) {
-                    throw new RuntimeException($validationResult->validationErrorMessage);
-                }
-
-                $urlValidator = new UrlValidator();
-                $validationResult = $urlValidator->validate($value);
-                if (!$validationResult->isValid) {
-                    throw new RuntimeException($validationResult->validationErrorMessage);
-                }
-
-                $urlSchemeHttpsValidator = new UrlSchemeHttpsValidator($urlValidator);
-                $validationResult = $urlSchemeHttpsValidator->validate($value);
+                $compositeValidator = new CompositeValidator(
+                    [
+                        new NonEmptyStringValidator('URL'),
+                        new UrlSchemeHttpsValidator(new UrlValidator()),
+                    ]
+                );
+                $validationResult = $compositeValidator->validate($value);
                 if (!$validationResult->isValid) {
                     throw new RuntimeException($validationResult->validationErrorMessage);
                 }

src/Domain/Question/Validation/CompositeValidator.php

@@ -0,0 +1,27 @@
+<?php
+declare(strict_types=1);
+
+namespace thofman\KnowledgeBase\Domain\Question\Validation;
+
+final readonly class CompositeValidator implements Validator
+{
+    /**
+     * @param list<Validator> $validators
+     */
+    public function __construct(
+         private array $validators,
+    ) {
+    }
+
+    public function validate(string $value): ValidationResult
+    {
+        $validationResult = ValidationResult::valid($value);
+        foreach ($this->validators as $validator) {
+            $validationResult = $validator->validate($validationResult->value);
+            if (!$validationResult->isValid) {
+                return $validationResult;
+            }
+        }
+        return $validationResult;
+    }
+}