Allocate on the heap instead of the stack to avoid segfaults#27
Open
mattdurham wants to merge 9 commits intothorhs:masterfrom
Open
Allocate on the heap instead of the stack to avoid segfaults#27mattdurham wants to merge 9 commits intothorhs:masterfrom
mattdurham wants to merge 9 commits intothorhs:masterfrom
Conversation
Author
|
@thorhs seeing if you had a chance to review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caveat: I am not the best C++ programer.
Previously perf objects were allocated on the heap which by default is 96Kb on AIX. When dealing with a large number of perf instances this would case a segfault/invalid argument when calling the libperfstat function. Confused as to why it did not cause it on allocation, but moving to the heap solves the issue.
Added manual deletion of the objects, the memory could leak if an error occurred but that would involve a lot more SED work than I could easily do and in testing with customer environments we haven't seen any errors.