Improve retry logic and add tests for server error handling #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refines GotenbergClient's retry logic to distinguish between retryable and non-retryable server errors based on status codes and error message patterns. Adds an internal isRetryableServerError method and updates sendRequestWithRetry to use it for 500 errors. Introduces comprehensive unit tests in RetryBehaviorTests.swift to verify correct retry behavior for various error scenarios. Updates README with improved documentation and usage examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refines GotenbergClient's retry logic to distinguish between retryable and non-retryable server errors based on status codes and error message patterns. Adds an internal isRetryableServerError method and updates sendRequestWithRetry to use it for 500 errors. Introduces comprehensive unit tests in RetryBehaviorTests.swift to verify correct retry behavior for various error scenarios. Updates README with improved documentation and usage examples.