kernel: Ensure manager is valid before installing fd#3115
Merged
Conversation
Or if manager is not crowned, -1 will pass the check when userspace calls setresuid(-1, -1, -1) and incorrectly install fd for whatever app. Luckily, first setuid is usually called when zygote forks into app and task flag is unmarked there, so this is not a security issue.
KOWX712
pushed a commit
to KOWX712/KernelSU
that referenced
this pull request
Dec 29, 2025
Or if manager is not crowned, userspace can pass the check if calling setresuid(-1, -1, -1). Luckily, first setuid is usually called when zygote forks into app and task flag is unmarked there, so this is not a security issue.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
Or if manager is not crowned, userspace can pass the check if calling setresuid(-1, -1, -1). Luckily, first setuid is usually called when zygote forks into app and task flag is unmarked there, so this is not a security issue.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
Or if manager is not crowned, userspace can pass the check if calling setresuid(-1, -1, -1). Luckily, first setuid is usually called when zygote forks into app and task flag is unmarked there, so this is not a security issue.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 8, 2026
Or if manager is not crowned, userspace can pass the check if calling setresuid(-1, -1, -1). Luckily, first setuid is usually called when zygote forks into app and task flag is unmarked there, so this is not a security issue.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 13, 2026
Or if manager is not crowned, userspace can pass the check if calling setresuid(-1, -1, -1). Luckily, first setuid is usually called when zygote forks into app and task flag is unmarked there, so this is not a security issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Or if manager is not crowned, userspace can pass the check if calling setresuid(-1, -1, -1). Luckily, first setuid is usually called when zygote forks into app and task flag is unmarked there, so this is not a security issue.