feat(android): global DrawerLayout for BottomNavigation#14228
Draft
feat(android): global DrawerLayout for BottomNavigation#14228
Conversation
…ndroidBottomDrawer
Contributor
Author
|
The last bigger part "showing the icon" is not working 😞 I can add Bildschirmaufnahme_20250725_154737.mp4but as soon as I click it it will be gone. Opening/closing it with code works and the button is also syncing the state. It just disappears as soon as you click it 🤷 |
Contributor
Author
|
with the help of opencode.ai I was able to fix the disappearing icon 👍 not 100% happy with the code yet but I'm glad it works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add a DrawerLayout around the new BottomNavigation so you don't need to add it in every window and it is in-front of everything.
Bildschirmaufnahme_20250519_195742.webm
Todo:
I'm copying the parts from the normal DrawerLayout code.