Conversation
|
Thank you for the PR! Similarly to #389, I've kicked off the actions on it but I'll hold of reviewing until Emil has had a chance to look at the corresponding tidyclust PR. |
|
Quick note on the comment on line 16 of |
|
@kbodwin Could you turn that into an issue instead of the code comment? That makes it much easier to keep track of in the longer term. |
hfrick
left a comment
There was a problem hiding this comment.
Thanks for the PR! I see Emil has moved on the corresponding tidyclust PR, so I'll add my comments here. This looks good! In addition to the point above about turning a code comment into a GH issue, could you please also
- fix the pkgdown action by adding the new parameters to
_pkgdown.yml - add a NEWS bullet for your contribution in the style of https://style.tidyverse.org/news.html
Thank you!
@kbodwin
Adds new function for min_support to dials to support adding freq_itemsets to tidyclust, see tidymodels/tidyclust#210