reduce heartbeat message #313
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: linning <linningde25@gmail.com>
Contributor
Contributor
|
@NingLin-P have we done any benchmark? |
Member
Author
Not yet. |
Signed-off-by: linning <linningde25@gmail.com>
|
Hello, excuse me. I would like to ask if there is benchmark in this PR? |
Member
Author
I think there is no, this PR has been paused for a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: linning linningde25@gmail.com
When there is no pending Readindex, MsgAppend will do the work of MsgHeartbeat, so when we had broadcasted MsgAppend, we can reset heartbeat_elapsed to reduce MsgHeartbeat.
close #309