Open
Conversation
… accidently committed years ago.
rfortier
force-pushed
the
tweak/Basic-clang-fixes
branch
from
674f8eb to
59aec9e
Compare
Member
|
Alongside with this we should ensure that our entire ocde is properly formatted, and that CI rejects badly formatted PRs imho. What does @miredirex think abt that? |
Collaborator
|
Yeah I will get to that, but after we release 1.8.1 |
Contributor
Author
|
Yes, we've been talking about that. This is just a warmup, the simplest/safest possible fix so clang-format works in Visual Studio again (without manual fixups to the tree that you tend to lose on branch changes). Then @miredirex was going to tweak the settings for a bigger fix. But again, after the next dot release; baby steps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop .clang-format ColumnLimit to 180 (from 300) so lines fit on less than an ultra-wide.
Delete incorrect .clang-format accidently committed years ago.