Skip to content

Log forwarded 4xx errors#46

Merged
Askir merged 10 commits intomainfrom
log-forwarded-errors-4xx
Oct 9, 2025
Merged

Log forwarded 4xx errors#46
Askir merged 10 commits intomainfrom
log-forwarded-errors-4xx

Conversation

@Askir
Copy link
Contributor

@Askir Askir commented Oct 7, 2025

Relies on: https://github.com/timescale/savannah-public/pull/49
The errors for these cases are still suboptimal:

  • Creating more than 2 free services (insufficient permission -> Error: Unauthorized. Entitlement check has failed.)
  • Forking more than 2 free services (insufficient permission -> Error: Unauthorized. Entitlement check has failed.)
  • Forking before a backup is read (still gives a 500)
  • Forking to an invalid (too early timestamp) (still gives a 500)

Will dive a bit deeper into graphql to try get better errors. At least it should be propagated with this.

@Askir Askir marked this pull request as ready for review October 7, 2025 14:30
@Askir Askir requested a review from nathanjcochran October 7, 2025 14:30
Copy link
Member

@nathanjcochran nathanjcochran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple minor comments, but no show-stoppers. Looks good to me ✅

I definitely think there's more we could do to clean up the error handling, but that could be done in a follow-up. This gets the job done for now 👍.

Copy link
Contributor

@cevian cevian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over this and looks reasonable but will let @nathanjcochran take lead on review. Suggest to add text to CLAUDE.md to specify how this should be handled

@Askir Askir force-pushed the log-forwarded-errors-4xx branch from f2ebcfc to 546173d Compare October 8, 2025 15:33
@Askir Askir force-pushed the log-forwarded-errors-4xx branch 2 times, most recently from d06b4c0 to 8fc79c8 Compare October 8, 2025 18:27
@Askir Askir force-pushed the log-forwarded-errors-4xx branch from 8fc79c8 to c4005d4 Compare October 8, 2025 18:36
@Askir Askir merged commit 570c06d into main Oct 9, 2025
2 checks passed
@Askir Askir deleted the log-forwarded-errors-4xx branch October 9, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants