AGE-120: display message when new version available by murrayju · Pull Request #54 · timescale/tiger-cli

murrayju · 2025-10-10T18:18:04Z

This pulls the latest release version number from the (configurable) S3 bucket url, compares it to the current version, and outputs a message when outdated. This is performed at most once per hour (also configurable), with the last check time stored in the config file.

We attempt to determine the installation method based on the current binary's path, and output a helpful message for how to upgrade as well (e.g. brew upgrade tiger-cli).

I made tiger version skip this implicit check, instead adding an explicit tiger version --check that forces checking (regardless of last check time).

Finally, I also implemented some --output options for the version command, to conform to table formatting by default, with json, yaml, and bare (only the version number) to making parsing for scripting tasks easier.

Includes the new version when --check is used

-o bare will be easiest to just capture the version number

murrayju · 2025-10-10T20:01:08Z

I created an alpha prerelease from this branch to test this out on the various platforms.

Can get the binary via:

curl -fsSL https://tiger-cli-releases.s3.amazonaws.com/install/install.sh | VERSION=v0.0.0-alpha.20  sh

macos

curl

homebrew

linux

curl

deb

rpm + dnf

docker run --rm -it -v ~/Downloads/tiger-cli-0.0.0.alpha.20-1.aarch64.rpm:/tmp/package.rpm rockylinux:9 bash -c "dnf install -y /tmp/package.rpm && tiger version --check"

rpm + yum

docker run --rm -it -v ~/Downloads/tiger-cli-0.0.0.alpha.20-1.aarch64.rpm:/tmp/package.rpm centos:7 bash -c "yum install -y /tmp/package.rpm && tiger version --check"

murrayju · 2025-10-10T20:14:10Z

internal/tiger/cmd/config.go

+		table.Append("version_check_interval", fmt.Sprintf("%d seconds", *cfg.VersionCheckInterval))
+	}
+	if cfg.VersionCheckLastTime != nil {
+		table.Append("version_check_last_time", time.Unix(int64(*cfg.VersionCheckLastTime), 0).Format(time.RFC1123))


I figured it'd be nice for the table output format to be more human readable. Open to a different formatting choice, or just the raw number if people think that's better.

murrayju · 2025-10-10T20:19:06Z

internal/tiger/cmd/root.go

+				return fmt.Errorf("failed to load config: %w", err)
+			}
+
+			if err := logging.Init(cfg.Debug); err != nil {


I fixed this unrelated bug, where debug from the config file/env was not being used (only the cli flag worked)

murrayju · 2025-10-10T20:24:46Z

scripts/install.sh

    # Test that the binary is executable and get version
    local installed_version
-    if installed_version=$("${binary_path}" version 2>/dev/null | head -n1 || echo ""); then
+    if installed_version=$("${binary_path}" version -o bare 2>/dev/null | head -n1 || echo ""); then


To fix this:

cevian

Looks mostly good but I would like to see if we can use more of golang's time and interval types natively

internal/tiger/cmd/root.go

internal/tiger/cmd/version.go

internal/tiger/config/config.go

internal/tiger/version/check.go

cevian · 2025-10-13T13:43:47Z

internal/tiger/version/check.go

+}
+
+// DetectInstallMethod determines how Tiger CLI was installed
+func detectInstallMethod(binaryPath string) InstallMethod {


dislike this but don't know if there is a better way. We could run tiger config set install_method deb and similar in post-install scripts. but that has its own complexity (which I think is better but wont inisist).

The GitHub cli uses detection (similar to this), but they also only bother to detect homebrew.

I do think good detection logic is going to be more reliable than writing to the config file, which can easily be altered/reset. Either way, it is easy to think of ways to break it... we could bail on attempts to be helpful, and instead show a more generic "update according to your install method" message (or no message at all).

This is again a case of code written by Claude, that I tested and appears to work well. I'm not convinced that there is a good reason to rework it a different way.

cevian · 2025-10-13T13:49:12Z

internal/tiger/version/check.go

+		}
+		return "sudo yum update tiger-cli"
+	case InstallMethodInstallSh:
+		return "curl -fsSL https://tiger-cli-releases.s3.amazonaws.com/install/install.sh | sh"


will have to remember to replace when changing url (Not to self)

This helps, but I think we'll also change the subpath
7b25e54

nathanjcochran

Didn't get far into reviewing, but left a couple minor comments about things I noticed.

Can continue reviewing tomorrow if Mat doesn't get to it first.

internal/tiger/cmd/config.go

nathanjcochran · 2025-10-14T21:52:39Z

internal/tiger/cmd/config_test.go

+		"releases_url":           "https://cli.tigerdata.com",
+		"version_check_interval": float64(3600000000000), // JSON unmarshals time.Duration as nanoseconds (1 hour = 3600000000000ns)


This test doesn't appear to check for the presence of version_check_last_time. Might be good to include (I think all of the other config options are included here 🤔). Same for the other tests below.

If the problem is that version_check_last_time is non-deterministic, we might want to stub out time.Now and mock it in these tests. That's usually done like this:

Do this in the code itself, and call now() instead of time.Now()

var now = time.Now

Do this to mock it in the tests (and don't forget to reset it when the test is finished, either via a defer call or T.Cleanup):

now = func() time.Time { return time.Date(2025, time.October, 14, 12, 0, 0, 0, time.UTC) }

cevian

a few optional comments

cevian · 2025-10-15T08:23:41Z

internal/tiger/cmd/version.go

 		},
 	}
+
+	cmd.Flags().BoolVar(&checkVersion, "check", false, "Check for the latest version")


I still don't get why we don't just use the existing global. but don't feel too strongly

This is to force a check, regardless of last check time. The global is --skip-update-check. Maybe you are thinking --skip-update-check=false? That doesn't quite seem clear enough to me, plus it is much more to type.

This should help: f322c16

internal/tiger/config/config.go

murrayju added 4 commits October 10, 2025 13:44

basic version check working

db59df8

colorful output, print last

91a0626

Use -o bare for install script version output

8417dca

do semver compare

95e584b

murrayju marked this pull request as ready for review October 10, 2025 20:07

murrayju added 2 commits October 10, 2025 16:10

revert CLAUDE.md change

a4994a4

better test workaround

af42ce2

murrayju commented Oct 10, 2025

View reviewed changes

cevian requested changes Oct 13, 2025

View reviewed changes

murrayju and others added 10 commits October 14, 2025 10:05

use releases_url in cfg, construct sub paths

7b25e54

don't skip for version command

13be93c

util functions for writing json/yaml

042735a

improved homebrew detection

b30627b

use time/duration types

10c1ec6

avoid checking twice

76fd8e2

24h default

e9237d0

fix tests

72ea255

skip check in CI, no tty

73663c2

Merge branch 'main' into murrayju/version-check

5b39e3e

murrayju requested a review from cevian October 14, 2025 16:12

murrayju and others added 2 commits October 14, 2025 17:10

Merge branch 'main' into murrayju/version-check

2336870

url changes

589b674

nathanjcochran reviewed Oct 14, 2025

View reviewed changes

cevian approved these changes Oct 15, 2025

View reviewed changes

murrayju and others added 5 commits October 15, 2025 09:50

Improve flag description

f322c16

guard against future times

cd05cc9

Merge branch 'main' into murrayju/version-check

dcf4a5e

abc sort keys

c60d7aa

include version_check_last_time in config tests

13d73c6

murrayju merged commit cb63bb5 into main Oct 15, 2025
2 checks passed

murrayju deleted the murrayju/version-check branch October 15, 2025 16:09

murrayju mentioned this pull request Oct 15, 2025

Improved download of CLI, default service creation timescale/tiger-eon#28

Merged

		"releases_url": "https://cli.tigerdata.com",
		"version_check_interval": float64(3600000000000), // JSON unmarshals time.Duration as nanoseconds (1 hour = 3600000000000ns)

Conversation

murrayju commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

murrayju commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

macos

curl

homebrew

linux

curl

deb

rpm + dnf

rpm + yum

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cevian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nathanjcochran left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nathanjcochran Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cevian left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

murrayju commented Oct 10, 2025 •

edited

Loading

murrayju commented Oct 10, 2025 •

edited

Loading

nathanjcochran Oct 14, 2025 •

edited

Loading