Merged
Conversation
nathanjcochran
force-pushed
the
nathan/fix-S3-directory
branch
from
36b92e2 to
43d1330
Compare
murrayju
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in #56.
GoReleaser is treating
directory: ""in the S3 blob config the same as an omitteddirectoryconfig, which is causing it to use its built-in default of{{ .ProjectName }}/{{ .Tag }}instead of the bucket root 🙄.This fixes it by instead using a Go template that outputs an empty string (
{{ "" }}), since the field supports templates, and this gets around the defaulting behavior while maintaining the same end result. There might be other ways to fix it too, but there's nothing about it in the docs, and this seems to work (I went ahead and releasedv0.9.2from this branch to verify - probably should have just done that in the first place 😅 ).