Merged
Conversation
murrayju
approved these changes
Oct 16, 2025
Member
murrayju
left a comment
murrayju
left a comment
There was a problem hiding this comment.
Looks good, one minor comment
internal/tiger/cmd/spinner.go
Outdated
| fmt.Fprintln(s.output, s.model.View()) | ||
| } | ||
|
|
||
| func isTerminal(w io.Writer) bool { |
Member
There was a problem hiding this comment.
I wrote a similar function for the version check stuff. Should consolidate these.
Reviewing on mobile, too hard to provide a link, sorry.
Member
Author
There was a problem hiding this comment.
Good call! Done here: ac42720.
I decided to rely on the official golang.org/x/term package rather than the github.com/mattn/go-isatty package you were using. I think the functionality should be essentially the same, but I trust the official package slightly more.
nathanjcochran
force-pushed
the
nathan/increase-polling-frequency
branch
from
309d8c0 to
26dd0ca
Compare
nathanjcochran
force-pushed
the
nathan/increase-polling-frequency
branch
from
26dd0ca to
ac42720
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR increases the polling frequency when creating or deleting services from every 10 seconds to every 1 second.
Additionally, to avoid spamming the console with lots of
Service status: QUEUED...messages (which were previously output every time we polled), I implemented a more dynamic status message that updates in real-time and shows a little loading spinner thingy:Screen.Recording.2025-10-15.at.6.11.34.PM.mov
If the output is not a tty, it doesn't try to render the dynamic loading spinner/message, but instead prints the status message on a new line every time the message changes. This is to prevent weird terminal control characters from showing up in the output when it's redirected to a file.
I also fixed some buggy and duplicate error output.
Closes AGE-188