Merged
Conversation
nathanjcochran
commented
Oct 21, 2025
Comment on lines
+40
to
+41
| - name: ShellCheck | ||
| run: shellcheck scripts/install.sh |
Member
Author
There was a problem hiding this comment.
Moved this up from below because it's extremely fast, and better to give fast feedback on the install script than make people wait for all the tests to run.
murrayju
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs
go mod tidy --diffin the CI pipeline, to ensure that thego.modandgo.sumfiles correctly reflects the modules needed by the source code (i.e. no missing modules and no extra unused modules). This is basically a way to make sure people rungo mod tidyafter adding/removing dependencies.Per
go help mod tidy: